adds ResetOffset to reset to earlier offset values. #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm quite happy with how this looks, thanks! @wvanbergen you had some thoughts on this originally. |
hasnickl
reviewed
Oct 3, 2017
| pom.lock.Lock() | ||
| defer pom.lock.Unlock() | ||
|
|
||
| if offset < pom.offset { |
There was a problem hiding this comment.
updating the metadata without changing the offset.
I don't think either of us ever considered a use case for that. I suppose it would be easy enough to make this a <=
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly meant as a start of a discussion, happy to change it. cf #554 for initial discussions and use cases.
Added ResetOffset on PartitionOffsetManager that allows setting the offset to a value less than the current value.
From a downstream perspective I would prefer to have a single func to call that allows setting an offset to a smaller or greater value, regardless of the current value - but thought API-wise it'd make more sense to have MarkOffset and ResetOffset act as duals/complements. What do you think?